Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp_field to the documentation #1544

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Conversation

ApolloLV
Copy link
Contributor

Description

I noticed the documentation references timestamp_field in several places, but never actually documents the field itself.
I added a short description of what it does to the documentation.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

As this changes no actual source code, I have skipped the tests.
I'm not sure if we need to mention this pure documentation change in the changelog?

@jertel
Copy link
Owner

jertel commented Sep 27, 2024

Thanks for taking the time to add this missing piece. Yes, please update the CHANGELOG.md. I prefer to over communicate, even if it's a small doc change.

@ApolloLV
Copy link
Contributor Author

I've added it to the changelog and merged in the current master. Should be good to go now.

@jertel jertel merged commit 2a2fb59 into jertel:master Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants