Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Python 3.13 #1551

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented Oct 9, 2024

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu nsano-rururu requested a review from jertel October 9, 2024 18:33
@jertel jertel merged commit 193c841 into jertel:master Oct 9, 2024
1 check passed
@jertel
Copy link
Owner

jertel commented Oct 9, 2024

ReadTheDocs failed to build the doc set. I put that file only back to 3.12.

image

@nsano-rururu nsano-rururu deleted the upgrade_python313 branch October 9, 2024 23:47
@Karql
Copy link

Karql commented Nov 30, 2024

You should add breaking change to release https://github.com/jertel/elastalert2/releases/tag/2.21.0 because you dropped version 3.12.

btw. IMO this drop was done too fast. You should consider alpine linux releases because this is very popular system.

@jertel
Copy link
Owner

jertel commented Nov 30, 2024

@Karql Thanks for bringing this up. I agree, the removal of 3.12 support should have been mentioned as a breaking change. It was properly marked as a breaking change in the previous release when 3.9-3.11 was dropped.

@nsano-rururu Was there a specific reason you removed support for 3.12? If not we can add that support back for a few more months.

@nsano-rururu
Copy link
Collaborator Author

@jertel

There's no particular reason.
You don't need to ask my consent for how to proceed from now on.
I haven't used elastalert2 for quite some time now.

@nsano-rururu
Copy link
Collaborator Author

@jertel

The elastalert2-server maintained by Karql uses a node docker image. Because it is based on alpine, it will take some time to get the latest python support.

@nsano-rururu
Copy link
Collaborator Author

@Karql

The background should be explained properly. It is an unofficial tool. elastalert2-server is

@Karql
Copy link

Karql commented Dec 1, 2024

There are many use cases for this tool.
For example, someone might run it directly on their system. There are systems that are more security-focused, where new application versions are added to the repository more slowly.

I see no reason to drop support for older Python versions.
None of the dependencies in use require this.
I also don’t see any specific features being used that are only available in newer Python versions.

Additionally, it's worth mentioning that version 3.12 will be supported for another 4 years.

image

Like I've said - In my opinion, dropping support for older versions just two days after the release of a new one is definitely too fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants