-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to Python 3.13 #1551
upgrade to Python 3.13 #1551
Conversation
You should add breaking change to release https://github.com/jertel/elastalert2/releases/tag/2.21.0 because you dropped version 3.12. btw. IMO this drop was done too fast. You should consider alpine linux releases because this is very popular system. |
@Karql Thanks for bringing this up. I agree, the removal of 3.12 support should have been mentioned as a breaking change. It was properly marked as a breaking change in the previous release when 3.9-3.11 was dropped. @nsano-rururu Was there a specific reason you removed support for 3.12? If not we can add that support back for a few more months. |
There's no particular reason. |
The elastalert2-server maintained by Karql uses a node docker image. Because it is based on alpine, it will take some time to get the latest python support. |
The background should be explained properly. It is an unofficial tool. elastalert2-server is |
There are many use cases for this tool. I see no reason to drop support for older Python versions. Additionally, it's worth mentioning that version 3.12 will be supported for another 4 years. Like I've said - In my opinion, dropping support for older versions just two days after the release of a new one is definitely too fast. |
Description
Checklist
make test-docker
with my changes.Questions or Comments