Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telegram parse_mode option #924

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Add telegram parse_mode option #924

merged 2 commits into from
Aug 8, 2022

Conversation

polshe-v
Copy link
Contributor

@polshe-v polshe-v commented Aug 8, 2022

Description

Added more parsing modes for Telegram and made separate option for setting parse_mode in alert rule. In order to make alert_text look pretty in all modes I added conditional alert_text formatting for markdown and html.

Checklist

  • I have reviewed the contributing guidelines.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.

Comments

There was a problem running make test-docker:

py310 run-test: commands[1] | flake8 --config ../setup.cfg .
./loaders_test.py:85:8: E275 missing whitespace after keyword
./loaders_test.py:86:8: E275 missing whitespace after keyword
./loaders_test.py:112:8: E275 missing whitespace after keyword
./loaders_test.py:113:8: E275 missing whitespace after keyword
./loaders_test.py:138:8: E275 missing whitespace after keyword
./loaders_test.py:139:8: E275 missing whitespace after keyword
ERROR: InvocationError for command /home/elastalert/tests/.tox/py310/bin/flake8 --config ../setup.cfg . (exited with code 1)

I added whitespace after del in these strings and all tests worked fine, all passed.

Polina Sheviakova and others added 2 commits August 8, 2022 12:41
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically require all contribution checklist items be completed, but since your PR identified some new, unrelated linting errors, I completed the remaining requirements for you:

  • Added unit test coverage for new code
  • Added CHANGELOG.md entry
  • Clarified the new setting's documentation
  • Fixed unrelated lint errors

Please ensure future PRs have all contribution requirements completed, or leave the PR in a draft mode until it's ready to be reviewed.

Thanks for your contribution!

@jertel jertel merged commit 91b5967 into jertel:master Aug 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants