Fix +at(slice-name)

[Djules]

Fix the related bug when using +at() mixin with the slice's name instead
of its measure

[jescalan]

This looks good to me @Djules! Thanks for also going the extra mile and adding tests. As long as @declandewet signs off on this I would say we're good to merge. Thanks for the excellent contribution!

[Djules]

I actually found an error when using +at('xl') so please wait for the next merge...

[jescalan]

Cool, is this ready now @Djules?

[Djules]

Exactly @Jenius !

The private function -get-index() should return the number of the slice (start at 1) instead of its zero-based index. Maybe you should rename it as -get-scale-number or something like that.

[zspecza]

This looks good - I like the idea of changing the name of that function if you think it might read better. I dont have the time to do it myself so if you can include that change here then this will be ready to merge, otherwise it's not such a big deal and can be merged in anyway. Up to you @Djules

[jescalan]

Awesome, let me know if/when that function name is changed and we can get this merged up 👍

[Djules]

So I renamed the function to -get-scale-number and I have removed its second argument, because I don't see the point of a loosely coupled function if this function returns no more than a position of a scale in a list, but I may be wrong with that.

Let me know what you think. :)

[jescalan]

Yup, that seems like the right approach to me. Don't implement until you need it.