-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: qBittorrent: Update the status filter behavior #237
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 78.79% 78.63% -0.17%
==========================================
Files 57 57
Lines 9211 9212 +1
Branches 917 908 -9
==========================================
- Hits 7258 7244 -14
- Misses 1945 1957 +12
- Partials 8 11 +3
Continue to review full report at Codecov.
|
None of the changes is effective. Note that switch statements fallthroughs till Additionally, rTorrent and ruTorrent are two distinct pieces of software. It is inappropriate to use |
The main reason for this PR is that there is currently no apparent way to filter I only mention ruTorrent because it was de-facto the main rTorrent webui before Flood so maybe there is some experience or design to inherit. Disregard if you don't care |
I don't think that's necessary. IMO there is zero reason to make "stopped" distinct from "paused". It only creates more confusion. |
Hi, are you still championing this PR? If yes, you would have to at least make it actually effective. (and respond to my comments) if no, feel free to close the PR. |
I don't think there's any code logic present against that.
I tested it and it is effective. One torrent is only at a state at the time, it won't need to go past I'm still arguing that the current UX doesn't provide a easy way to resume previously paused torrents that aren't finished downloading, which is a necessary function. There are a lot of circumstances people need to pause their torrents and resume afterwards, and there isn't an apparent queue in flood right now to address that. Right now I will need to go Hope that address your confusion. There are a few ways for this:
|
You don’t need to change any backend code for this. What you want is a filter that contains “stopped” but not “completed”. |
case 'downloading': | ||
case 'forcedDL': | ||
statuses.push('active'); | ||
statuses.push('downloading'); | ||
break; | ||
case 'pausedDL': | ||
statuses.push('inactive'); | ||
statuses.push('downloading'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only effective line.
@@ -62,16 +62,22 @@ export const getTorrentStatusFromState = (state: QBittorrentTorrentState): Torre | |||
statuses.push('downloading'); | |||
break; | |||
case 'metaDL': | |||
statuses.push('downloading'); | |||
break; | |||
case 'downloading': | |||
case 'forcedDL': | |||
statuses.push('active'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metaDL
previously goes to here. Your change only removes active
from the status. Is that intended? metaDL
should be an active status.
statuses.push('stopped'); | ||
break; | ||
case 'queuedDL': | ||
statuses.push('inactive'); | ||
statuses.push('downloading'); | ||
break; | ||
case 'stalledDL': | ||
statuses.push('inactive'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
queuedDL
previously goes to here. Your change is not effective.
server: qBittorrent: Update the status filter behavior so that UX is in sync with qB GUI/WebUI.
Description
Mainly appends 'pausedDL' torrents to 'Downloading' status.
I understand rtorrent/rutorrent may have the design of classifying torrent status, and I'm not sure if you want to unify the logic for the current three backends, but this PR would be more natural logically for qBittorrent users.
Adjustment based on:
https://github.com/CzBiX/qb-web/blob/809d5bab4b5b4566cd3d74eb6e5df243fb4a17c1/src/utils.ts#L4
Types of changes