Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query cache reset #105

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

kzaitsev
Copy link
Contributor

@kzaitsev kzaitsev commented Aug 5, 2020

Right now upsert for ActiveRecord 6.0 + doesn't reset query cache. This compatibility patch fixes it.

https://github.com/rails/rails/blob/6-0-stable/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb#L17

Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clear and understandable fix for a an issue in Rails 6. Thanks!

@olleolleolle olleolleolle merged commit 3231033 into jesjos:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants