Document differences between this gem and ActiveRecord::Persistence#upsert #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
reviewed
Nov 9, 2022
olleolleolle
reviewed
Nov 9, 2022
olleolleolle
approved these changes
Nov 9, 2022
|
"Comparing to native Rails 6 Upsert" perhaps should be "Comparing to native Rails upsert (from Rails 6.0)". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @olleolleolle! Wanted to take a stab at #95. I recently went through upgrading a legacy codebase from Rails 5 to Rails 6 and in the process we wanted to see what the differences were between https://github.com/jesjos/active_record_upsert and the Rails native #upsert feature. Figured it would be good information for others to have.
For now I put it on the README, but if there's somewhere else you think we should put it, happy to move it around. Thanks!