Fix specs about upsert_keys and literal #71
Conversation
|
(Thanks for the thoughtful repair of the |
| @@ -44,7 +44,7 @@ module ActiveRecord | |||
| end | |||
| context 'different ways of setting keys' do | |||
| let(:attrs) { {make: 'Ford', name: 'Focus', long_field: SecureRandom.uuid} } | |||
| before { Vehicle.create(attrs) } | |||
| let!(:vehicule) { Vehicle.create(attrs) } | |||
There was a problem hiding this comment.
Would it work with before?
There was a problem hiding this comment.
The removed line before { Vehicle.create(attrs) } was useless, it should have been written before { @vehicle = Vehicle.create(attrs) }.
Changing let!(:vehicule) { Vehicle.create(attrs) } by let(:vehicule) { Vehicle.create(attrs) } recreate vehicle object on each tests. May be it's better for tests integrity...
There was a problem hiding this comment.
The current documentation on let and let!:
https://relishapp.com/rspec/rspec-core/v/3-7/docs/helper-methods/let-and-let
Let's keep the French wording in there. And use let!. In this case, we would like to recalculate before each test, so let! it is.
A word about the key specs.
In the key specs, an instance was created like :
upserted = Vehicle.new(id: v.id, wheels_count: 1).But this one doesn't pass the validation because the field
nameis empty.The
upsertreturns false because of the error on the validation.So yes the assertion
expect(upserted.id).to eq(vehicule.id)is always true, but nothing happens in the DB: the spec doesn't test anything.About the literal key.
I miss the thing (in #70) that due to
extract_options!, theliteralkey is removed fromupsert_keysand stored in theupsert_optionsattribute (like thewhereattribute).So we don't have to check to class of
upsert_key, but just check if theupsert_optionsconstains theliteralkey.I trust the specs, but nothing happend in DB.