Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rails 6 #92

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Support Rails 6 #92

merged 3 commits into from
Apr 26, 2019

Conversation

tjwallace
Copy link
Contributor

Closes #91.

@tjwallace tjwallace marked this pull request as ready for review April 25, 2019 20:38
@tjwallace
Copy link
Contributor Author

tjwallace commented Apr 25, 2019 •
edited
Loading

Let me know what you think of the TravisCI build matrix changes - 11 + 2 builds is quite a lot, maybe we should set the ruby version to only 2.6.2 and be done with it?

@tjwallace tjwallace mentioned this pull request Apr 25, 2019
Closed
olleolleolle
olleolleolle reviewed Apr 26, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
olleolleolle
olleolleolle approved these changes Apr 26, 2019
View reviewed changes
Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a stunner 🎈

Thank you for creating this!

Supporting newer ActiveRecord versions and keeping compatibility with the slow-poke versions we care about, this PR takes us into the present.

Good job!

@olleolleolle olleolleolle merged commit e8972ce into jesjos:master Apr 26, 2019
@tjwallace tjwallace deleted the rails6 branch April 26, 2019 16:51
@tjwallace
Copy link
Contributor Author

No problem @olleolleolle!

Do you plan on creating a new release (or beta release) soon?

@olleolleolle
Copy link
Collaborator

@tjwallace How about right now?

@tjwallace
Copy link
Contributor Author

@olleolleolle that sounds great, thanks!

@olleolleolle
Copy link
Collaborator

OK, now there's a tag, and there's a GitHub Release, so RubyGems' release will fall out of that as a publish hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Active Record 6
2 participants
@tjwallace @olleolleolle