Add upsert_keys and upsert_options as opts #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahuang65
force-pushed
the
master
branch
2 times, most recently
from
dd40a48 to
9dbcabf
Compare
hahuang65
changed the title
|
I can't seem to figure out why these tests are failing for Rails 5.1 and 5.0. The index looks to be in place from those Travis logs... |
|
Never mind, figured it out. There was a change I needed to make in the compatibility layer. |
This allows setting of `upsert_keys` and `upsert_options` directly when calling `#upsert` or `.upsert`. This will overwrite the default `upsert_keys` and `upsert_options` set in the model.
|
+1 That will be really helpful |
|
Any chance we can get this in? |
olleolleolle
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting of
upsert_keysandupsert_optionsdirectly whencalling
#upsertor.upsert. This will overwrite the defaultupsert_keysandupsert_optionsset in the model.Resolves #74