Code review fixes

jesseduffield · Jul 31, 2023 · 808c159 · 808c159
1 parent 5f8a894
commit 808c159
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/gui/controllers/helpers/merge_and_rebase_helper.go b/pkg/gui/controllers/helpers/merge_and_rebase_helper.go
@@ -225,7 +225,7 @@ func (self *MergeAndRebaseHelper) RebaseOntoRef(ref string) error {
 			Key:   's',
 			OnPress: func() error {
 				self.c.LogAction(self.c.Tr.Actions.RebaseBranch)
-				return self.c.WithLoaderPanel(self.c.Tr.RebaseWait, func(task gocui.Task) error {
+				return self.c.WithWaitingStatus(self.c.Tr.Actions.Rebase, func(task gocui.Task) error {
 					baseCommit := self.c.Modes().MarkedBaseCommit.GetSha()
 					var err error
 					if baseCommit != "" {

diff --git a/pkg/i18n/english.go b/pkg/i18n/english.go
@@ -60,7 +60,6 @@ type TranslationSet struct {
 	NoChangedFiles                      string
 	PullWait                            string
 	PushWait                            string
-	RebaseWait                          string
 	FetchWait                           string
 	SoftReset                           string
 	AlreadyCheckedOutBranch             string
@@ -617,6 +616,7 @@ type Actions struct {
 	ForceCheckoutBranch               string
 	DeleteBranch                      string
 	Merge                             string
+	Rebase                            string
 	RebaseBranch                      string
 	RenameBranch                      string
 	SetUnsetUpstream                  string
@@ -803,7 +803,6 @@ func EnglishTranslationSet() TranslationSet {
 		NoChangedFiles:                      "No changed files",
 		PullWait:                            "Pulling...",
 		PushWait:                            "Pushing...",
-		RebaseWait:                          "Rebasing...",
 		FetchWait:                           "Fetching...",
 		SoftReset:                           "Soft reset",
 		AlreadyCheckedOutBranch:             "You have already checked out this branch",
@@ -1339,6 +1338,7 @@ func EnglishTranslationSet() TranslationSet {
 			ForceCheckoutBranch:               "Force checkout branch",
 			DeleteBranch:                      "Delete branch",
 			Merge:                             "Merge",
+			Rebase:                            "Rebasing",
 			RebaseBranch:                      "Rebase branch",
 			RenameBranch:                      "Rename branch",
 			SetUnsetUpstream:                  "Set/Unset upstream",