Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX for committing and tagging is non-obvious #4134

Closed
doga opened this issue Jan 1, 2025 · 5 comments · Fixed by #4136
Closed

UX for committing and tagging is non-obvious #4134

doga opened this issue Jan 1, 2025 · 5 comments · Fixed by #4136
Labels
enhancement New feature or request

Comments

@doga
Copy link

doga commented Jan 1, 2025

Is your feature request related to a problem? Please describe.

To finalize a commit, I must go back from commit description to commit summary, and then hit return. It is not obvious that the user has to go back, nor is it sensible. But maybe I am missing something.

Screenshot 2025-01-01 at 01 19 30

Describe the solution you'd like

There should be a way of finalizing the commit when the commit description field is in focus (unless commit summary field is empty), such as a keyboard shortcut and/or a button.

Describe alternatives you've considered

One solution that works is to move the focus back to the commit summary field, and then hit return.

@doga doga added the enhancement New feature or request label Jan 1, 2025
@stefanhaller
Copy link
Collaborator

You can press shift-return to commit from the description field. The only problem with this is that it's not obvious or discoverable, but once you know it, it works quite well.

@jesseduffield
Copy link
Owner

We could show the shift+enter keybinding at the bottom left of the screen to make it (slightly) more discoverable

@stefanhaller
Copy link
Collaborator

(It's alt-enter of course, I got that wrong.)

I was just working on adding the keybinding to the legend on the top-right when the description panel is focused; that would work well, but it gets a little crowded, and looks bad on very small screens. I'll try to add it at the bottom.

@stefanhaller
Copy link
Collaborator

Here's a PR: #4136

@doga
Copy link
Author

doga commented Jan 2, 2025

Thanks. If both fields accepted the same keyboard shortcut it would be easier to remember.

@doga doga closed this as completed Jan 2, 2025
stefanhaller added a commit that referenced this issue Jan 3, 2025
…4136)

- **PR Description**

It wasn't really obvious how to commit when the focus is in the commit
description view, since pressing enter inserts a newline there. To
improve this, show the `<a-enter>` keybinding at the bottom of the
description view when it is focused.

Fixes #4134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants