Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-deadlock version to fix crash with go 1.23 in debug mode #4248

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

ChrisMcD1
Copy link
Contributor

  • PR Description

This PR solves #4002, and perhaps #3880 (if they are indeed duplicates), and the error message preventing debugging in #3973.

The problem is that our version of go-deadlock transitively depends on a version of goid that predates their changes to support go 1.23, which results in every goid being the number 2 for some reason. Bumping the version of go-deadlock to include the updated transitive dependency means that the goids are now correct, and go-deadlock does not confused why goroutine 2 is trying to lock so many things.

I know very little about go vendored dependencies, so all I have done is edit the go.mod entry for go-deadlock to be v0.3.5, and then run a go mod tidy and go mod vendor. If there is a more correct way to bump a vendored dependency, feel free to close this PR and just do that!

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Feb 10, 2025
@stefanhaller
Copy link
Collaborator

Thanks! Looks great.

I know very little about go vendored dependencies, so all I have done is edit the go.mod entry for go-deadlock to be v0.3.5,

The usual way to make such a change is to type go get github.com/sasha-s/go-deadlock, but the result is the same in this case.

@stefanhaller stefanhaller merged commit 1909545 into jesseduffield:master Feb 10, 2025
15 checks passed
@ChrisMcD1 ChrisMcD1 deleted the go-deadlock-bump branch February 10, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance For refactorings, CI changes, tests, version bumping, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants