Bump go-deadlock version to fix crash with go 1.23 in debug mode #4248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #4002, and perhaps #3880 (if they are indeed duplicates), and the error message preventing debugging in #3973.
The problem is that our version of
go-deadlock
transitively depends on a version ofgoid
that predates their changes to support go1.23
, which results in every goid being the number2
for some reason. Bumping the version ofgo-deadlock
to include the updated transitive dependency means that the goids are now correct, andgo-deadlock
does not confused why goroutine 2 is trying to lock so many things.I know very little about go vendored dependencies, so all I have done is edit the
go.mod
entry forgo-deadlock
to be v0.3.5, and then run ago mod tidy
andgo mod vendor
. If there is a more correct way to bump a vendored dependency, feel free to close this PR and just do that!go generate ./...
)