Add test for #91 #96
Merged
Add test for #91 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for jessekrubin#91
|
Sick! Looookin good Billy ray. |
|
Looking at this more I am still not sure it is making the composite correctly The old @mapbox/glyph-pbf-composite gave this as a composite If i get rid setting the name in the test, the result looks more like that file, except the range is 0-255 instead of 5120-5375. If I make the expected file the old one from glyph-pbf-composite, it seems to show that difference |
|
I can take a look when I get home. If I had to guess the id range should not be set from the id. |
This was referenced Aug 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for #91 . This test shows the issue I mentioned.
After #93
Before that commit
