Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up, docs, minor refactor(s) 🧹 #38

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Conversation

jessepeterson
Copy link
Owner

Various clean-up, documentation improvements, and a couple of (mostly minor) refactors:

  • Make the logging keys consistent by introducing a new package called logkeys (similar to NanoCMD). Resolves Consistent logging key names #12
  • Flesh out OpenAPI docs (temporary link). Resolves OpenAPI docs #4
  • For the DDM endpoints store the Enrollment ID on the context and log it with all follow-on context loggers.
  • Move most of the storage interfaces from the http/api package into the storage package. Resolves Move storage interfaces to storage package #3
  • Make non-optional initializer values panic() for HTTP Handlers and various New() functions.
  • Misc test additions and improvements.
  • Misc documentation improvements (most exported symbols now have GoDoc comments).
  • Refactor ddm.*Builder interfaces.
  • Refactor the notifier package to abstract the DeclarativeManagement MDM command sending (notifying):
    • Import and use NanoCMD's "foss" command enqueuer

@jessepeterson jessepeterson changed the title clean up, docs, minor refactor(s) clean up, docs, minor refactor(s) 🧹 Jul 26, 2023
@jessepeterson jessepeterson merged commit 8c6c5ab into main Aug 1, 2023
3 checks passed
@jessepeterson jessepeterson deleted the cleanup-Jul2023 branch August 1, 2023 18:14
@jessepeterson jessepeterson linked an issue Aug 1, 2023 that may be closed by this pull request
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant