Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: search field for GUI grep of available updates #16

Closed
tallfunnyjew opened this issue Dec 19, 2012 · 12 comments
Closed

Comments

@tallfunnyjew
Copy link

like a repoutil --list

great to have a GUI search field somewhere in the top margarita menubar that allows for search/display of various updates. something like the attached.

also, it'd be great if you made the margarita logo a link to the github discussion group. good times. love your work, cheers.

d

margarita-searchbar

@jessepeterson
Copy link
Owner

Agreed. It is a "planned" feature. Just need the time to implement! Sort of related to #6 as well.

@tallfunnyjew
Copy link
Author

right on. happy to help with any graphics/coding i can. i'm no expert but i
love your product, jesse.

d

On Wed, Dec 19, 2012 at 2:13 PM, Jesse Peterson notifications@git.luolix.topwrote:

Agreed. It is a "planned" feature. Just need the time to implement!


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-11551244.

@jessepeterson
Copy link
Owner

Come to think of it--and you mentioning graphics--have you made icons before? I've been thinking about a minimalist "cocktail" icon for the product. Martini icon would probably be most.. iconic, not sure what's different about a an image of a margarita. Placement would be somewhere on the GitHub page and in the Twitter Bootstap bar near/to the left of the "Margarita" text.

@tallfunnyjew
Copy link
Author

hey jesse:

i'm on vacation but lemme get to work on this when i get back to los
angeles. i have made icons before. long before i was a sysadmin, i had a
rich history building websites and, sometimes, still do.

d

On Thu, Dec 27, 2012 at 2:04 AM, Jesse Peterson notifications@git.luolix.topwrote:

Come to think of it--and you mentioning graphics--have you made icons
before? I've been thinking about a minimalist "cocktail" icon for the
product. Martini icon would probably be most.. iconic, not sure what's
different about a an image of a margarita. Placement would be somewhere on
the GitHub page and in the Twitter Bootstap bar near/to the left of the
"Margarita" text.


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-11704754.

@tallfunnyjew
Copy link
Author

got a few stylized images of a margarita for you attached. lemme know.
margarita-draft 1
margarita-draft2

@tallfunnyjew
Copy link
Author

here's a couple more for ya!

margarita-draft3
margarita-draft4

@tallfunnyjew
Copy link
Author

do any of the above work for ya, jesse?

@tallfunnyjew
Copy link
Author

so i've been making a few changes to your margarita.html template file and have, as you can see, made a few simple changes:

  1. I've hot linked the word "Margarita" in the upper left of each page to open a new browser tab/window and point to this github distro. i figure it's best if folks can join the conversation.

  2. i added one of the margarita icons to, you know, just help give the joint a little splash of color... it adds a larger white border to the top of the page, but it looks nice.

Screen Shot 2013-03-05 at 5 07 41 PM

I'd tried posting a smaller version of the image (as you'd suggested) in the upper left of the screen but... it doesn't look good because the image needs to be less than 40px in height. kinda kills any fun icon that i'd already made. but happy to send along those edits and/or post them. and to keep on creating a better icon anyhoo.

@jessepeterson
Copy link
Owner

Thanks for your work! Sorry I've been a bit MIA. If you can give me a couple/few weeks and I can take a more dedicated look. THanks!

@jessepeterson
Copy link
Owner

But also wanted to add: definitely fork and commit your changes either way!

@jessepeterson
Copy link
Owner

After looking at the icons and thinking on for a bit - I think I would prefer the smaller icon in the menu bar - the white space kinda bugs me with the larger graphic.

However, this is one condition where a larger graphic could be permitted. In the default install with only the Apple branch (no other branches) and the "Hide commonly listed updates" box checked there are no results and page looks rather empty. Some descriptive text might be helpful here and next to it could be this larger icon.

In either case I've opened a new issue specifically for the graphics so as to return this issue to it's rightful cause: a search field. :) The new issue is #21.

@jessepeterson
Copy link
Owner

Implemented a filter text input field (commit 0af9d82). The filter text box is implemented after the hide commonly listed updates filter so will only filter those products that are showing currently. Also it only searches on the title of the product. Not sure if other search fields would be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants