Prevent crash when types are mismatched #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ejensen ! I will take a look at this soon 😊 |
|
thanks so much @ejensen ! 🙌🏼 |
|
I've sent an invite to make you a collaborator with push access. 🎉 |
|
And this has been released: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This change prevents a force-casting crash when fetching a wrapped value with mismatched types.
nilis returned instead. A mismatched type can be caused by a redefinition of a key or data corruption. The change allows Foil intergrators to handle thenilcase rather than crashing. This change does not impact the public interface and adds a unit test to verify mismatched types are handled.