Add and run SwiftLint

#5

.swiftlint.yml

@@ -0,0 +1,106 @@
+excluded:
+  - Pods
+  - docs
+  - build
+  - scripts
+
+disabled_rules:
+  # metrics
+  - nesting
+
+  # lint
+  - notification_center_detachment
+  - weak_delegate
+
+  # idiomatic
+  - force_cast
+  - type_name
+
+  # style
+  - identifier_name
+
+opt_in_rules:
+  # performance
+  - empty_count
+  - first_where
+  - sorted_first_last
+  - contains_over_first_not_nil
+  - last_where
+  - reduce_into
+  - contains_over_filter_count
+  - contains_over_filter_is_empty
+  - empty_collection_literal
+  - type_contents_order
+
+  # idiomatic
+  - fatal_error_message
+  - xctfail_message
+  - discouraged_object_literal
+  - discouraged_optional_boolean
+  - discouraged_optional_collection
+  - for_where
+  - function_default_parameter_at_end
+  - legacy_random
+  - no_extension_access_modifier
+  - redundant_type_annotation
+  - static_operator
+  - toggle_bool
+  - unavailable_function
+  - no_space_in_method_call
+
+  # style
+  - attributes
+  - number_separator
+  - operator_usage_whitespace
+  - sorted_imports
+  - vertical_parameter_alignment_on_call
+  - void_return
+  - closure_spacing
+  - empty_enum_arguments
+  - implicit_return
+  - modifier_order
+  - multiline_parameters
+  - trailing_closure
+  - unneeded_parentheses_in_closure_argument
+  - vertical_whitespace_between_cases
+
+  # lint
+  - overridden_super_call
+  - yoda_condition
+  - anyobject_protocol
+  - array_init
+  - empty_xctest_method
+  - identical_operands
+  - prohibited_super_call
+  - unused_import
+  - unused_capture_list
+  - duplicate_enum_cases
+  - legacy_multiple
+  - unused_declaration
+
+line_length: 200
+file_length: 600
+
+type_body_length: 500
+
+function_body_length: 250
+
+cyclomatic_complexity: 15
+
+type_contents_order:
+  order:
+    - associated_type
+    - type_alias
+    - case
+    - subtype
+    - type_property
+    - ib_outlet
+    - ib_inspectable
+    - instance_property
+    - initializer
+    - deinitializer
+    - subscript
+    - type_method
+    - view_life_cycle_method
+    - ib_action
+    - other_method

README.md

@@ -10,7 +10,7 @@ Blog posts:
 Overriding status bar display settings in the iOS simulator](https://www.jessesquires.com/blog/overriding-status-bar-settings-ios-simulator/)
 * [A script to automate overriding iOS simulator status bar values](https://www.jessesquires.com/blog/automating-simctl-status-bar/)
 
-[Xcode 11](https://developer.apple.com/documentation/xcode_release_notes/xcode_11_release_notes) shipped with `simctl status_bar`, a tool to override the status bar values in the simulator so you can take perfect screenshots. 
+[Xcode 11](https://developer.apple.com/documentation/xcode_release_notes/xcode_11_release_notes) shipped with `simctl status_bar`, a tool to override the status bar values in the simulator so you can take perfect screenshots.
 
 However, it has some issues:
 * The overrides do not persist across launches of the simulator
@@ -19,6 +19,12 @@ However, it has some issues:
 
 This script fixes that. It overrides the status bars for all currently running simulators using "Apple's defaults" — full cellular bars, full wifi bars, full battery, and `9:41` for the time.
 
+## Requirements
+
+- Swift 5.2+
+- Xcode 11.4+
+- [SwiftLint](https://github.com/realm/SwiftLint)
+
 ## Contributing
 
 Interested in making contributions to this project? Please review the guides below.

nine41.swift

@@ -12,13 +12,13 @@ import Foundation
 
 extension String {
     var nsRange: NSRange {
-        return NSRange(location: 0, length: self.count)
+        NSRange(location: 0, length: self.count)
     }
 }
 
 extension StringProtocol {
     var byTrimmingWhiteSpace: String {
-        return self.trimmingCharacters(in: .whitespacesAndNewlines)
+        self.trimmingCharacters(in: .whitespacesAndNewlines)
     }
 }
 
@@ -44,14 +44,15 @@ extension Process {
     /// Executes `xcrun simctl list devices`
     @discardableResult
     func xcrun_list_devices() -> Data {
-        return self.xcrun("simctl", "list", "devices", "-j")
+        self.xcrun("simctl", "list", "devices", "-j")
     }
 
     /// Executes `xcrun simctl status_bar` on the specified device.
     ///
     /// - Parameter device: The device for which status bar values should be overridden.
     func xcrun_fix_status_bar(_ device: String) {
-        let magicDate = Date(timeIntervalSince1970: 1168364460) // 9:41 AM PT on Tuesday January 9, 2007
+        // 9:41 AM PT on Tuesday January 9, 2007
+        let magicDate = Date(timeIntervalSince1970: 1_168_364_460)
         let time = ISO8601DateFormatter().string(from: magicDate)
 
         self.xcrun(
@@ -71,9 +72,9 @@ extension Process {
 print("Fixing status bars...")
 
 let deviceData = Process().xcrun_list_devices()
-let json = (try! JSONSerialization.jsonObject(with: deviceData, options: [])) as! Dictionary<String, Any>
-let runtimes = json["devices"] as! Dictionary<String, Array<Any>>
-let allDevices = runtimes.values.flatMap { $0 } as! Array<Dictionary<String, AnyHashable>>
+let json = (try? JSONSerialization.jsonObject(with: deviceData, options: [])) as! [String: Any]
+let runtimes = json["devices"] as! [String: [Any]]
+let allDevices = runtimes.values.flatMap { $0 } as! [[String: AnyHashable]]
 
 var fixed = false
 

scripts/lint.sh

@@ -0,0 +1,36 @@
+#!/bin/bash
+
+#  Created by Jesse Squires
+#  https://www.jessesquires.com
+#
+#  Copyright © 2020-present Jesse Squires
+#
+#  SwiftLint
+#  https://github.com/realm/SwiftLint/releases/latest
+#  ------------------------------
+
+VERSION="0.39.2"
+FOUND=$(swiftlint version)
+
+if which swiftlint >/dev/null; then
+    swiftlint lint --config ./.swiftlint.yml
+    exit
+else
+    echo "
+    Error: SwiftLint not installed!
+    Download from https://github.com/realm/SwiftLint,
+    or brew install swiftlint.
+    "
+fi
+
+if [ $(swiftlint version) != $VERSION ]; then
+    echo "
+    Warning: incorrect SwiftLint installed!
+    Expected: $VERSION
+    Found: $FOUND
+    Download from https://github.com/realm/SwiftLint,
+    or brew upgrade swiftlint.
+    "
+fi
+
+exit