rmapi: Update to 0.0.13 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates rmapi to 0.0.13. This gives a few benefits (like having authentication errors) but most usefully includes additional support for XDG_CONFIG_DIR for storing tokens rather than requiring them to be stored in $HOME.
endocrimes
commented
Dec 10, 2020
| @@ -32,10 +32,11 @@ func New() (Remarkable, error) { | |||
| log.InitLog() | |||
|
|
|||
| for i := 0; i < rmAuthRetries; i++ { | |||
| rm = api.CreateApiCtx(api.AuthHttpCtx()) | |||
| var err error | |||
| rm, err = api.CreateApiCtx(api.AuthHttpCtx(false, false)) | |||
There was a problem hiding this comment.
The AuthHttpCtx here added two arguments:
- the first being
reAuthwhich forces a reauth regardless of an existing token. I've gone for false here because that seems unnecessary? - the second being
nonInteractivewhich would result in failure if there isn't a valid authentication token already. It might be useful to include a flag for running on servers here but I've avoided doing it for now.
endocrimes
commented
Dec 10, 2020
| @@ -99,7 +100,7 @@ func (r Remarkable) SyncFileAndRename(file, title string) error { | |||
| r.api.Filetree.AddDocument(*document) | |||
|
|
|||
| // Move the file to the title. | |||
| docName := util.DocPathToName(filepath.Base(file)) | |||
| docName, _ := util.DocPathToName(filepath.Base(file)) | |||
There was a problem hiding this comment.
The extra value is the file extension - which we don't need here.
|
This fixes #6 right? I tried using this PR but ended up with SIGSEV: |
|
@david-caro huh interesting - I haven't rebuilt this since I opened the PR, but it was working at the time. I'll take a look at fixing it tomorrow. Looks like some case returns err == nil and rm == nil potentially. |
It seems I'm getting unauthorized error, it only shows when debug is enabled: |
|
I bumped rmapi to 0.0.15 and it worked now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates rmapi to 0.0.13.
This gives a few benefits (like having authentication errors) but most usefully includes additional support for
$XDG_CONFIG_DIRfor storing tokens rather than requiring them to be stored in$HOME.