fix(no-identical-titles): support nested describes (#790)

jest-community · Mar 10, 2021 · ce26621 · ce26621
1 parent e5561d6
commit ce26621
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/rules/__tests__/no-identical-title.test.ts b/src/rules/__tests__/no-identical-title.test.ts
@@ -125,6 +125,15 @@ ruleTester.run('no-identical-title', rule, {
       ${'a'}
     \`("$description", () => {})
     `,
+    dedent`
+    describe("top level", () => {
+      describe.each\`\`("nested each", () => {
+        describe.each\`\`("nested nested each", () => {})
+      })
+
+      describe("nested", () => {})
+    })
+    `,
   ],
   invalid: [
     {

diff --git a/src/rules/no-identical-title.ts b/src/rules/no-identical-title.ts
@@ -42,13 +42,14 @@ export default createRule({
       CallExpression(node) {
         const currentLayer = contexts[contexts.length - 1];
 
+        if (isDescribe(node)) {
+          contexts.push(newDescribeContext());
+        }
+
         if (node.callee.type === AST_NODE_TYPES.TaggedTemplateExpression) {
           return;
         }
 
-        if (isDescribe(node)) {
-          contexts.push(newDescribeContext());
-        }
         const [argument] = node.arguments;
 
         if (!argument || !isStringNode(argument)) {