test.each no-done-callback false positive in version 24.1.2

[voda]

Very similar to #709, but there is still a false positive when the test function has 2 arguments.

Plugin version: 24.1.2
Last working version: 24.1.0
Rule jest/no-done-callback has false positives with test.each

it.each([
	[1, 2],
	[2, 4],
	[3, 6],
])('.double(%i)', async (a: number, expected: number) => {
	expect(2 * a).toBe(expected);
});

[jsaguet]

I just had the same issue.

After having a quick look at the rule implementation, it seems the logic is to check the number of arguments of the test function.

But for test.each / it.each used with a table, just checking the number of arguments of the function will never work.
I think the only way to enforce this rule in this case is to check if the last argument is actually called in the function block statement.

[voda]

I think the only way to enforce this rule in this case is to check if the last argument is actually called in the function block statement.

The list of test cases can also contain a callback, so I don't think that would work.

it.each([
	[1, () => 2],
])(...);

I think jest is also checking the number of arguments: https://github.com/facebook/jest/blob/f9132f9106e3f1b3ae6f81d1f36222055c3fe111/packages/jest-each/src/bind.ts#L81-L83

[github-actions]

🎉 This issue has been resolved in version 24.1.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀