fix(no-identical-titles): support nested describes #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
## [24.2.1](v24.2.0...v24.2.1) (2021-03-10) ### Bug Fixes * **no-identical-titles:** support nested describes ([#790](#790)) ([ce26621](ce26621))
|
🎉 This PR is included in version 24.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 10, 2021
Merged
Merged
build(deps-dev): bump eslint-plugin-jest from 24.2.0 to 24.2.1
mastermunj/typescript-boilerplate#328
Merged
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, because we pop the describe context on
CallExpression:exit, but not insert one in the case of a template describe.each, we try to usedescribeTitlesof undefined.