Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade @typescript-eslint/utils to v6 #1401

Closed
wants to merge 1 commit into from
Closed

feat: upgrade @typescript-eslint/utils to v6 #1401

wants to merge 1 commit into from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 13, 2023

There are so many breaking changes in v6 I don't think we'll be able to properly support v5 and v6 at the same time...

I started here and just ended up frustrated 😛 @G-Rath I dunno if you wanna give it a whack?

@SimenB SimenB requested a review from G-Rath July 13, 2023 14:49
@G-Rath
Copy link
Collaborator

G-Rath commented Jul 14, 2023

@SimenB just to check, do we need to support both or move to v6 right now? I'm still triaging the new major and so far it looks like everything still works fine from a consumer POV but want to double check I've not missed something.

@SimenB
Copy link
Member Author

SimenB commented Jul 25, 2023

I'd prefer to have CI verify it works with both, but there is no rush at all. It's totally fine to stay on the old version for now

@quantizor
Copy link

quantizor commented Aug 18, 2023

ooc if this linter plugin isn't updated to the new version and @typescript-eslint/*@6 is used in a linting setup, will that cause problems with both versions being installed and potentially used simultaneously?

I ask because the newer version has some desirable stuff in it like code to leverage the TS projects service... would be very helpful for larger repos.

@SimenB
Copy link
Member Author

SimenB commented Aug 19, 2023

You can use v6 of the plugin already

@quantizor
Copy link

You can use v6 of the plugin already

Oh, what is this PR doing then?

@erunion

This comment was marked as resolved.

@G-Rath

This comment was marked as resolved.

@G-Rath G-Rath changed the title fix: support @typescript-eslint/eslint-plugin v6 feat: upgrade @typescript-eslint/utils to v6 Aug 30, 2023
Copy link

🎉 This issue has been resolved in version 28.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Apr 6, 2024

🎉 This issue has been resolved in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants