Add danger #15
Add danger #15
Conversation
|
Hrnm, interesting - looks like one of Danger's dependencies is a |
|
Woo! Still failing CI because of node 6. Would using build stages allow us to only run danger on one env (e.g. node 8)? https://docs.travis-ci.com/user/build-stages |
CHANGELOG.md
Outdated
| @@ -0,0 +1,7 @@ | |||
| // Please add your own contribution below inside the Master section // These | |||
| docs are aimed at users rather than danger developers, so please limit technical | |||
There was a problem hiding this comment.
"danger" should probably not be here
|
I've added a separate changelog, causing a conflict. (I still want to use conventional commits and just generate it, but now it's there, at least) |
|
I've now deleted the changelog as semantic-release is setup. I'd still love to have the test report from jest and lint report from eslint inline. Danger supports that, right? Not sure how to deal with node 4. Keen on dropping it, it messes up for semantic release as well :P |
|
Hah - sorry for letting this drop for so long, still mid-way on a big deadline, but I've switched it up to have danger only run on 8 and to remove the CHANGELOG rule. Right now it only has one simple "all PRs must have a description" rule. Can expand later 👍 |
|
OK - that's that 👍 |
.travis.yml
Outdated
| node_js: 8 | ||
| os: linux | ||
| script: | ||
| - yarn add -D danger@^2 |
There was a problem hiding this comment.
@cpojer where is my yarn exec danger ;)
dangerfile.js
Outdated
|
|
||
| const { danger, fail } = require('danger'); | ||
|
|
||
| // Ensure that people include a description on their PRss |
|
Nice, updated 👍 |
$ npx danger@^2
npx: installed 110 in 4.601s
child process exited with code 0
Request failed [404]: https://api.github.com/repos/jest-community/eslint-plugin-jest/statuses/f66f69562d184115afb2865338910b717be15d1f
Response: {
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3/repos/statuses/#create-a-status"
}
No issues or messages were sent. Removing any existing messages.Are we supposed to get the 404? |
|
We've added |
|
Lols, I should wrap up this PR, yep |
|
@orta let me know if I can help out with this one! 👋 |
|
Ah yeah, the CI fail is nothing to do with danger |
orta
force-pushed
the
add_danger
branch
2 times, most recently
from
f66f695
to
aad7cfb
Compare
|
Rebased 👍 |
|
The trick was the ordering of the tasks in the travis.yml 👍 |
|
Does this matter?
https://travis-ci.org/jest-community/eslint-plugin-jest/jobs/340160669#L471 |
Adds:
rules/*includes a CHANGELOG entry