Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prioritize labelling pull requests based on their title rather than their commits #1564

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Apr 24, 2024

I think this will be better for most pull requests since conventional commits tends to mean either applying at the pull request level or only ever doing one commit; in practical terms, this means we can use cc in the context of a pull requests commits without getting both the "enhancement" and "bug" label.

Really it probably makes sense to skip checking commits in most cases or even throw/post an error, but for now I've not done that because I expect the fallback to be triggered by external contributors and this workflow currently will only run when a new change it pushed; we could change that but given how stable we are these days I'm not going to do that for now.

@G-Rath G-Rath merged commit a63be2a into main Apr 24, 2024
30 checks passed
@G-Rath G-Rath deleted the feat-over-fix branch April 24, 2024 22:58
Copy link

🎉 This PR is included in version 28.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant