Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: only run linting when using ESLint v8 #1593

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented May 21, 2024

I've not dug into the actual code yet, but I'm pretty sure this is why #1590 is failing CI - more specifically, the latest version of eslint-plugin-n (which does not support ESLint v7) is now doing something v7 doesn't support

@G-Rath G-Rath requested a review from SimenB May 21, 2024 22:12
@G-Rath G-Rath marked this pull request as ready for review May 21, 2024 22:12
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:old-man-yells-at-code:

@SimenB SimenB merged commit da993a5 into main May 21, 2024
37 checks passed
@SimenB SimenB deleted the skip-linting-on-old-eslint branch May 21, 2024 22:20
Copy link

github-actions bot commented Jun 6, 2024

🎉 This PR is included in version 28.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants