Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade markdown-link-check to known working version and make it louder #1697

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jan 14, 2025

It seems that something is broken with the latest version(s) when using a config file; in the long-run it might be best to migrate to another tool but for now this should get our CI passing.

I've also removed the -q(uiet) flag in CI since logs are free and that could make it easier to debug in future

Resolves #1696

@G-Rath G-Rath requested a review from SimenB January 14, 2025 18:57
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, great stuff! thank you! 😀

@SimenB SimenB merged commit eecc6e6 into main Jan 14, 2025
52 checks passed
@SimenB SimenB deleted the fix-link-checker branch January 14, 2025 22:27
Copy link

🎉 This PR is included in version 28.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown link check is failing
2 participants