style(lint): enable node/no-unsupported-features rule #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Feb 11, 2018
package.json
Outdated
| @@ -47,5 +47,8 @@ | |||
| }, | |||
| "commitlint": { | |||
| "extends": ["@commitlint/config-conventional"] | |||
| }, | |||
| "dependencies": { | |||
| "eslint-plugin-es5": "^1.2.0" | |||
There was a problem hiding this comment.
Oops, good catch!
SimenB
reviewed
Feb 11, 2018
.eslintrc.js
Outdated
| @@ -8,7 +8,7 @@ module.exports = { | |||
| 'plugin:eslint-plugin/recommended', | |||
| 'prettier', | |||
| ], | |||
| plugins: ['eslint-plugin', 'prettier'], | |||
| plugins: ['es5', 'eslint-plugin', 'prettier'], | |||
There was a problem hiding this comment.
I would prefer https://github.com/mysticatea/eslint-plugin-node and no-unsupported-features
There was a problem hiding this comment.
I'll take a look at this and push up a new commit - thank you for the review. 🙂
macklinu
force-pushed
the
lint/no-destructuring
branch
from
236d098
to
255e1b6
Compare
macklinu
changed the title
|
@SimenB ready for another look |
macklinu
commented
Feb 11, 2018
| @@ -11,6 +11,9 @@ | |||
| "url": "jkimbo.com" | |||
| }, | |||
| "files": ["docs/", "rules/", "processors/", "index.js"], | |||
| "engines": { | |||
| "node": ">= 6" | |||
There was a problem hiding this comment.
Will this prevent users from installing the eslint-plugin-jest package on Node 4?
There was a problem hiding this comment.
oh oops, that was supposed to be 4. I just copied Jest's. Nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Enabling this rule should help prevent object destructuring errors on Travis CI for Node 4.