Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toHaveBeenCalledExactlyOnceWith typing #633

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

lukaselmer
Copy link
Contributor

@lukaselmer lukaselmer commented Jul 17, 2023

Fix toHaveBeenCalledExactlyOnceWith typing

What

Added parameters to toHaveBeenCalledExactlyOnceWith

Why

The parameters of toHaveBeenCalledExactlyOnceWith were missing (in one of the two places - the second place is correct)

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

🦋 Changeset detected

Latest commit: 9bff71c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jest-extended Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keeganwitt
Copy link
Collaborator

This looks right to me. Not sure how we missed it. Thanks for the PR!

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #633 (9bff71c) into main (e1e137a) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #633   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines          674       674           
  Branches       290       290           
=========================================
  Hits           674       674           

@keeganwitt keeganwitt merged commit bad7056 into jest-community:main Aug 3, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants