Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional owner-attribute for testcase #270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

work933k
Copy link

@work933k work933k commented Sep 5, 2024

This PR proposes to add support for defining the owner-attribute of testcase.
This attribute is used by Azure Devops' PublishTestResult-task

This should be a non-breaking change as the ownerName is optional.

@work933k work933k marked this pull request as ready for review September 5, 2024 11:12
@palmerj3
Copy link
Collaborator

palmerj3 commented Sep 5, 2024

Thanks for submitting a PR!

I need to do some work on the CI here before I'll be able to merge.

For this feature, I would like you to consider enabling different owners for different tests. Your approach assumes a single owner for an entire suite.

Have a look what we did to support custom test suite properties and an approach similar to that might be justified.

https://github.com/jest-community/jest-junit/blob/master/utils/buildJsonResults.js#L158

@work933k
Copy link
Author

work933k commented Sep 5, 2024

Thank you for your quick response.

I understand your suggestion to support different owners for different tests. But maybe it would be a good to initially start small/easy with this implementation?

@palmerj3
Copy link
Collaborator

palmerj3 commented Sep 5, 2024

Since you're adding a config / cli arg to specify the owner, if we move to multi-owner later on then that config goes away. Could be avoided altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants