-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Jest v28 #135
Allow Jest v28 #135
Conversation
d3f1f0d
to
cfec790
Compare
Release post: https://jestjs.io/blog/2022/04/25/jest-28
"jest-watch-select-projects": "^2.0.0", | ||
"jest-watch-typeahead": "^0.6.4", | ||
"jest-watch-typeahead": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only works in jest 27 and newer (as v1 is native ESM), but I guess watch mode isn't the most important thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does v0.x support jest 28? If so, we should probably downgrade it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the interface of watch plugins is unchanged
(there will be peer dep warnings, tho)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, then it’s still invalid - no chance of a v0.x bump with updated peer deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could upgrade to yarn v2 and use packageExtension
. Either way, it's just a warning locally, it won't be visible to consumers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about changing the semver here to be ^0.6.4 || ^1.1.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that works 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it only applies to this specific repo and no consumers, and we use yarn, I think it would work fine. but changing the range works as well
v1+ is not compatible with Jest 27 and earlier. See discussion: jest-community#135 (comment)
v1+ is not compatible with Jest 26 and earlier. See discussion: jest-community#135 (comment)
v1+ is not compatible with Jest 26 and earlier. See discussion: jest-community#135 (comment)
Release post:
https://jestjs.io/blog/2022/04/25/jest-28