Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Jest v28 #135

Merged
merged 1 commit into from
May 3, 2022
Merged

Allow Jest v28 #135

merged 1 commit into from
May 3, 2022

Conversation

lencioni
Copy link
Contributor

@lencioni lencioni commented May 2, 2022

@lencioni lencioni force-pushed the jest-28 branch 6 times, most recently from d3f1f0d to cfec790 Compare May 2, 2022 21:26
@ljharb ljharb merged commit cbddf13 into jest-community:main May 3, 2022
@lencioni lencioni deleted the jest-28 branch May 3, 2022 01:30
"jest-watch-select-projects": "^2.0.0",
"jest-watch-typeahead": "^0.6.4",
"jest-watch-typeahead": "^1.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only works in jest 27 and newer (as v1 is native ESM), but I guess watch mode isn't the most important thing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does v0.x support jest 28? If so, we should probably downgrade it.

Copy link
Member

@SimenB SimenB May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the interface of watch plugins is unchanged

(there will be peer dep warnings, tho)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, then it’s still invalid - no chance of a v0.x bump with updated peer deps?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could upgrade to yarn v2 and use packageExtension. Either way, it's just a warning locally, it won't be visible to consumers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about changing the semver here to be ^0.6.4 || ^1.1.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB yarn-specific features aren’t useful. #136 works tho

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it only applies to this specific repo and no consumers, and we use yarn, I think it would work fine. but changing the range works as well

lencioni added a commit to lencioni/jest-runner-eslint that referenced this pull request May 3, 2022
v1+ is not compatible with Jest 27 and earlier.

See discussion: jest-community#135 (comment)
lencioni added a commit to lencioni/jest-runner-eslint that referenced this pull request May 3, 2022
v1+ is not compatible with Jest 26 and earlier.

See discussion:

jest-community#135 (comment)
lencioni added a commit to lencioni/jest-runner-eslint that referenced this pull request May 3, 2022
v1+ is not compatible with Jest 26 and earlier.

See discussion:

jest-community#135 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants