Use jest-worker.
#32
Use jest-worker.
#32
Conversation
| @@ -1,6 +1,5 @@ | |||
| const throat = require('throat'); | |||
| const pify = require('pify'); | |||
| const workerFarm = require('worker-farm'); | |||
| const Worker = require('jest-worker').default; | |||
There was a problem hiding this comment.
.default is a babel implementation detail, and should never be exposed in an entry point. is there a bug filed on jest-worker for this?
There was a problem hiding this comment.
Would you mind filing one and linking to it here?
There was a problem hiding this comment.
I'm not very good with words, but I don't mind. What should I say in this issue?
There was a problem hiding this comment.
Whats up with this patch. It seems good to me. I don't see an issue with the .default thing. In fact, its how https://github.com/rogeliog/create-jest-runner/blob/master/lib/createJestRunner.js#L1 does it, which was recommended in issue #23
There was a problem hiding this comment.
I suppose it doesn't have to block this issue; but it's indeed a huge problem for babel interop details to pollute the ecosystem.
I've filed jestjs/jest#5803
src/runESLint.js
Outdated
| try { | ||
| const start = +new Date(); | ||
| module.exports.runESLint = ({ testPath, config }) => { | ||
| const start = +new Date(); |
There was a problem hiding this comment.
It was like that when I got here. Should I still fix it?
There was a problem hiding this comment.
Ah, fair enough. Not required, but it’d be nice :-)
src/runESLint.js
Outdated
| const options = getESLintOptions(config); | ||
| const cli = new CLIEngine(options.cliOptions); | ||
| if (cli.isPathIgnored(testPath)) { | ||
| const end = +new Date(); |
src/runESLint.js
Outdated
| const errorMessage = formatter( | ||
| CLIEngine.getErrorResults(report.results), | ||
| ); | ||
| const end = +new Date(); |
Maybe closes #23. I'm not too confident about it, though.