Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn Jest command in separate shell on Windows #248

Merged
merged 7 commits into from
Feb 21, 2018
Merged

Spawn Jest command in separate shell on Windows #248

merged 7 commits into from
Feb 21, 2018

Conversation

stephtr
Copy link
Member

@stephtr stephtr commented Feb 3, 2018

Should fix #98, adding .cmd won't be necessary anymore.
Updating jest-editor-support was necessary, jest-snapshot and jest-typescript-parser not, but I updated them anyway.

@stephtr
Copy link
Member Author

stephtr commented Feb 3, 2018

I didn't look through the other PRs, but it's probably better to close this in favor of #215.

@orta
Copy link
Member

orta commented Feb 20, 2018

Ok, so #215 is now in, shall I close this?

@seanpoulter
Copy link
Member

I'd leave it open. It's a quick change from src/JestExt.ts to the change from #215. @stephtr, did you want to have a look at this again?

@stephtr
Copy link
Member Author

stephtr commented Feb 20, 2018

I'll have a look at it in a few hours.

@stephtr
Copy link
Member Author

stephtr commented Feb 20, 2018

Before merging this PR index.d.ts in jest-editor-support has to be updated to include the shell property. I will submit a PR to jest.

@seanpoulter
Copy link
Member

Aren't we pulling types from typings/jest-editor-support.d.ts?

@stephtr
Copy link
Member Author

stephtr commented Feb 20, 2018

Ah thanks, I didn't notice that. Now it should be ready for merging.

@seanpoulter
Copy link
Member

Sweet. Thanks @stephtr.

@orta, when should we use the typings from jest-editor-support?

@orta
Copy link
Member

orta commented Feb 21, 2018

The ideal case is to move those typings back to jest-editor-extension every so often so others can get the value from them, but it's pretty ad-hoc

@orta
Copy link
Member

orta commented Feb 21, 2018

OK, I'm going to merge and ship this - it's the only PR in this release that I can't personally verify, so if this upcoming release is broken I'll need one of you two to take a look 💃

@orta orta merged commit 09c82ff into jest-community:master Feb 21, 2018
@stephtr
Copy link
Member Author

stephtr commented Feb 21, 2018

jest#5625 contains the typings update for jest-editor-support. There are two types remaining (TestResult and FormattedTestResults), which should be moved to typings/jest.d.ts as they belong to the jest package (which hasn't any TypeScript definitions at all), before jest-editor-support.d.ts can be removed.

legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
Spawn Jest command in separate shell on Windows
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception raised: Process failed: spawn node_modules\.bin\jest.cmd ENOENT
3 participants