-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawn Jest command in separate shell on Windows #248
Conversation
merge from jest-community/vscode-jest
I didn't look through the other PRs, but it's probably better to close this in favor of #215. |
Ok, so #215 is now in, shall I close this? |
I'll have a look at it in a few hours. |
Before merging this PR |
Aren't we pulling types from |
Ah thanks, I didn't notice that. Now it should be ready for merging. |
The ideal case is to move those typings back to jest-editor-extension every so often so others can get the value from them, but it's pretty ad-hoc |
OK, I'm going to merge and ship this - it's the only PR in this release that I can't personally verify, so if this upcoming release is broken I'll need one of you two to take a look 💃 |
jest#5625 contains the typings update for |
Spawn Jest command in separate shell on Windows
Merge pull request jest-community#248 from stephtr/master
Should fix #98, adding
.cmd
won't be necessary anymore.Updating
jest-editor-support
was necessary,jest-snapshot
andjest-typescript-parser
not, but I updated them anyway.