Refactor setting config from argv (#3424)

* Rename setState to updateArgv

* Add Argv type

* Remove unnecessary argv.help check

* Refactor setting config from argv

* Rename acc to options

* Use dot notation instead of string keys

* Make Options of updateArgv an exact type

* Move Argv type to it's own file

* Update showConfig snapshot with 'projects'

* Add missing options to args

* Update setFromArgv and Argv types

* Extract and reuse isJSON

* Update updateArgv.js

* Update validateCLIOptions.js

* Move regex check out of _replaceRootDirInObject

* Make explicit flags override those from --config

* Rename isJSON -> isJSONString

* Add reporters to args

integration_tests/__tests__/__snapshots__/showConfig-test.js.snap

@@ -73,6 +73,9 @@ exports[`jest --showConfig outputs config info and exits 1`] = `
     "mapCoverage": false,
     "noStackTrace": false,
     "notify": false,
+    "projects": [
+      "/mocked/root/path/jest/integration_tests/verbose_reporter"
+    ],
     "rootDir": "/mocked/root/path/jest/integration_tests/verbose_reporter",
     "testPathPattern": "",
     "testResultsProcessor": null,

integration_tests/__tests__/config-test.js

@@ -39,6 +39,16 @@ test('works with sane config JSON', () => {
 });
 
 test('watchman config option is respected over default argv', () => {
+  const {stdout} = runJest('verbose_reporter', [
+    '--env=node',
+    '--watchman=false',
+    '--debug',
+  ]);
+
+  expect(stdout).toMatch('"watchman": false');
+});
+
+test('config from argv is respected with sane config JSON', () => {
   const {stdout} = runJest('verbose_reporter', [
     '--config=' +
       JSON.stringify({

integration_tests/__tests__/coverage_report-test.js

@@ -78,6 +78,8 @@ test('outputs coverage report as json', () => {
   try {
     JSON.parse(stdout);
   } catch (err) {
-    throw new Error("Can't parse the JSON result from stdout" + err.toString());
+    throw new Error(
+      "Can't parse the JSON result from stdout. " + err.toString(),
+    );
   }
 });

integration_tests/runJest.js

@@ -34,9 +34,7 @@ function runJest(dir, args) {
     );
   }
 
-  const result = spawnSync(JEST_PATH, args || [], {
-    cwd: dir,
-  });
+  const result = spawnSync(JEST_PATH, args || [], {cwd: dir});
 
   result.stdout = result.stdout && result.stdout.toString();
   result.stderr = result.stderr && result.stderr.toString();