normalize icons across OSes in integration tests

integration-tests/Utils.js

@@ -48,15 +48,6 @@ const linkJestPackage = (packageName: string, cwd: Path) => {
   fs.symlinkSync(packagePath, destination, 'dir');
 };
 
-const fileExists = (filePath: Path) => {
-  try {
-    fs.accessSync(filePath, fs.F_OK);
-    return true;
-  } catch (e) {
-    return false;
-  }
-};
-
 const makeTemplate = (str: string): ((values?: Array<any>) => string) => {
   return (values: ?Array<any>) => {
     return str.replace(/\$(\d+)/g, (match, number) => {
@@ -175,14 +166,25 @@ const cleanupStackTrace = (output: string) => {
     .replace(/^.*at.*[\s][\(]?(\S*\:\d*\:\d*).*$/gm, '      at $1');
 };
 
+const normalizeIcons = (str: string) => {
+  if (!str) {
+    return str;
+  }
+
+  // Make sure to keep in sync with `jest-cli/src/constants`
+  return str
+    .replace(new RegExp('\u00D7', 'g'), '\u2715')
+    .replace(new RegExp('\u221A', 'g'), '\u2713');
+};
+
 module.exports = {
   cleanup,
   copyDir,
   createEmptyPackage,
   extractSummary,
-  fileExists,
   linkJestPackage,
   makeTemplate,
+  normalizeIcons,
   run,
   writeFiles,
 };

integration-tests/runJest.js

@@ -9,9 +9,10 @@
 'use strict';
 
 const path = require('path');
+const fs = require('fs');
 const execa = require('execa');
 const {Writable} = require('readable-stream');
-const {fileExists} = require('./Utils');
+const {normalizeIcons} = require('./Utils');
 
 const {sync: spawnSync} = execa;
 
@@ -37,7 +38,7 @@ function runJest(
   }
 
   const localPackageJson = path.resolve(dir, 'package.json');
-  if (!options.skipPkgJsonCheck && !fileExists(localPackageJson)) {
+  if (!options.skipPkgJsonCheck && !fs.existsSync(localPackageJson)) {
     throw new Error(
       `
       Make sure you have a local package.json file at
@@ -63,6 +64,9 @@ function runJest(
   // For compat with cross-spawn
   result.status = result.code;
 
+  result.stdout = normalizeIcons(result.stdout);
+  result.stderr = normalizeIcons(result.stderr);
+
   return result;
 }
 
@@ -102,7 +106,7 @@ runJest.until = async function(
   }
 
   const localPackageJson = path.resolve(dir, 'package.json');
-  if (!options.skipPkgJsonCheck && !fileExists(localPackageJson)) {
+  if (!options.skipPkgJsonCheck && !fs.existsSync(localPackageJson)) {
     throw new Error(
       `
       Make sure you have a local package.json file at
@@ -145,6 +149,9 @@ runJest.until = async function(
   // For compat with cross-spawn
   result.status = result.code;
 
+  result.stdout = normalizeIcons(result.stdout);
+  result.stderr = normalizeIcons(result.stderr);
+
   return result;
 };
 

scripts/SkipOnWindows.js

@@ -11,11 +11,6 @@
 
 const SkipOnWindows = {
   suite() {
-    if (process.platform === 'win32') {
-      fit('does not work on Windows', () => {
-        console.warn('[SKIP] Does not work on Windows');
-      });
-    }
   },
 };