Improve coverage threshold value (#9023)

* Improve coverage threshold value * Fix typespec * Fix linter * FIx typespec of threshold
jestjs · Oct 13, 2019 · 309d95a · 309d95a
1 parent 1d4bd5f
commit 309d95a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/packages/jest-reporters/src/coverage_reporter.ts b/packages/jest-reporters/src/coverage_reporter.ts
@@ -216,7 +216,7 @@ export default class CoverageReporter extends BaseReporter {
     if (globalConfig.coverageThreshold) {
       function check(
         name: string,
-        thresholds: {[index: string]: number},
+        thresholds: Config.CoverageThresholdValue,
         actuals: istanbulCoverage.CoverageSummaryData,
       ) {
         return (['statements', 'branches', 'lines', 'functions'] as Array<
@@ -226,7 +226,7 @@ export default class CoverageReporter extends BaseReporter {
           const actualUncovered = actuals[key].total - actuals[key].covered;
           const threshold = thresholds[key];
 
-          if (threshold != null) {
+          if (threshold !== undefined) {
             if (threshold < 0) {
               if (threshold * -1 < actualUncovered) {
                 errors.push(

diff --git a/packages/jest-types/src/Config.ts b/packages/jest-types/src/Config.ts
@@ -278,13 +278,16 @@ type DisplayNameColor =
   | 'bgCyanBright'
   | 'bgWhiteBright';
 
+export type CoverageThresholdValue = {
+  branches?: number;
+  functions?: number;
+  lines?: number;
+  statements?: number;
+};
+
 type CoverageThreshold = {
-  [path: string]: {
-    [key: string]: number;
-  };
-  global: {
-    [key: string]: number;
-  };
+  [path: string]: CoverageThresholdValue;
+  global: CoverageThresholdValue;
 };
 
 export type GlobalConfig = {