stack trace

jestjs · Mar 2, 2019 · 6b64186 · 6b64186
1 parent f17bcce
commit 6b64186
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/e2e/__tests__/declarationErrors.test.ts b/e2e/__tests__/declarationErrors.test.ts
@@ -14,6 +14,7 @@ it('warns if describe returns a Promise', () => {
 
   expect(result.status).toBe(0);
   expect(result.stdout).toMatch(/Tests must be defined synchronously/);
+  expect(result.stdout).toMatch(/at Object.describe/);
 });
 
 it('warns if describe returns something', () => {
@@ -23,4 +24,5 @@ it('warns if describe returns something', () => {
 
   expect(result.status).toBe(0);
   expect(result.stdout).toMatch(/"describe" callback must not return a value/);
+  expect(result.stdout).toMatch(/at Object.describe/);
 });
diff --git a/packages/jest-circus/src/index.ts b/packages/jest-circus/src/index.ts
@@ -68,13 +68,17 @@ const _dispatchDescribe = (
   // TODO throw in Jest 25
   if (isPromise(describeReturn)) {
     console.warn(
-      'Returning a Promise from "describe" is not supported. Tests must be defined synchronously.\n' +
-        'Returning a value from "describe" will fail the test in a future version of Jest.',
+      new ErrorWithStack(
+        'Returning a Promise from "describe" is not supported. Tests must be defined synchronously.\n' +
+          'Returning a value from "describe" will fail the test in a future version of Jest.',
+      ),
     );
   } else if (describeReturn !== undefined) {
     console.warn(
-      'A "describe" callback must not return a value.\n' +
-        'Returning a value from "describe" will fail the test in a future version of Jest.',
+      new ErrorWithStack(
+        'A "describe" callback must not return a value.\n' +
+          'Returning a value from "describe" will fail the test in a future version of Jest.',
+      ),
     );
   }
 

diff --git a/packages/jest-jasmine2/src/jasmine/Env.js b/packages/jest-jasmine2/src/jasmine/Env.js
@@ -379,13 +379,17 @@ export default function(j$) {
       // TODO throw in Jest 25: declarationError = new Error
       if (isPromise(describeReturnValue)) {
         console.warn(
-          'Returning a Promise from "describe" is not supported. Tests must be defined synchronously.\n' +
-            'Returning a value from "describe" will fail the test in a future version of Jest.',
+          new ErrorWithStack(
+            'Returning a Promise from "describe" is not supported. Tests must be defined synchronously.\n' +
+              'Returning a value from "describe" will fail the test in a future version of Jest.',
+          ),
         );
       } else if (describeReturnValue !== undefined) {
         console.warn(
-          'A "describe" callback must not return a value.\n' +
-            'Returning a value from "describe" will fail the test in a future version of Jest.',
+          new ErrorWithStack(
+            'A "describe" callback must not return a value.\n' +
+              'Returning a value from "describe" will fail the test in a future version of Jest.',
+          ),
         );
       }