Skip to content

Commit

Permalink
Clearify conditional setting of NODE_ENV (#7387)
Browse files Browse the repository at this point in the history
fixes #7369
  • Loading branch information
lukas-zech-software authored and rickhanlonii committed Nov 22, 2018
1 parent b3c10cb commit c01b4c7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
- `[pretty-format]` Standardize filenames ([#7316](https://github.com/facebook/jest/pull/7316))
- `[*]` Add check for Facebook copyright headers on CI ([#7370](https://github.com/facebook/jest/pull/7370))
- `[jest-haste-map]` Refactor `dependencyExtractor` and tests ([#7385](https://github.com/facebook/jest/pull/7385))
- `[docs]` Clearify conditional setting of `NODE_ENV` ([#7369](https://github.com/facebook/jest/pull/7369))

### Performance

Expand Down
2 changes: 1 addition & 1 deletion docs/GettingStarted.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ Don't forget to add a [`.babelrc`](https://babeljs.io/docs/usage/babelrc/) file
You are now set up to use all ES6 features and React specific syntax.
> Note: If you are using a more complicated Babel configuration, using Babel's `env` option, keep in mind that Jest will automatically define `NODE_ENV` as `test`. It will not use `development` section like Babel does by default when no `NODE_ENV` is set.
> Note: If you are using a more complicated Babel configuration, using Babel's `env` option, keep in mind that Jest will automatically define `NODE_ENV` as `test` **if not already set** to something else. It will not use `development` section like Babel does by default when no `NODE_ENV` is set.
> Note: If you've turned off transpilation of ES6 modules with the option `{ "modules": false }`, you have to make sure to turn this on in your test environment.
Expand Down

0 comments on commit c01b4c7

Please sign in to comment.