invert the logic

jestjs · May 30, 2017 · c87e010 · c87e010
1 parent 8fdfe5c
commit c87e010
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/integration_tests/__tests__/config-test.js b/integration_tests/__tests__/config-test.js
@@ -21,7 +21,7 @@ test('config as JSON', () => {
   ]);
   const stdout = result.stdout.toString();
 
-  expect(result.status).toBe(0);
+  expect(result.status).toBe(1);
   expect(stdout).toMatch('No tests found');
 });
 

diff --git a/...n_tests/__tests__/failWithNoTests-test.js → ...n_tests/__tests__/passWithNoTests-test.js b/...n_tests/__tests__/failWithNoTests-test.js → ...n_tests/__tests__/passWithNoTests-test.js
@@ -13,26 +13,26 @@ const runJest = require('../runJest');
 
 const DIR = path.resolve(__dirname, '../failWithNoTests');
 
-describe('jest --failWithNoTests', () => {
-  test("doesn't fail the test suite if no files are found", () => {
+describe('jest --passWithNoTests', () => {
+  test('fails the test suite if no files are found', () => {
     const result = runJest(DIR, ['--testPathPattern', '/non/existing/path/']);
     const status = result.status;
     const stdout = result.stdout.toString();
 
     expect(stdout).toMatch('No tests found');
-    expect(status).toBe(0);
+    expect(status).toBe(1);
   });
 
-  test('fails the test suite if no files are found', () => {
+  test("doesn't fail the test suite if no files are found", () => {
     const result = runJest(DIR, [
       '--testPathPattern',
       '/non/existing/path/',
-      '--failWithNoTests',
+      '--passWithNoTests',
     ]);
     const status = result.status;
     const stdout = result.stdout.toString();
 
     expect(stdout).toMatch('No tests found');
-    expect(status).toBe(1);
+    expect(status).toBe(0);
   });
 });
diff --git a/packages/jest-cli/src/cli/args.js b/packages/jest-cli/src/cli/args.js
@@ -169,11 +169,6 @@ const options = {
     description: 'Use this flag to show full diffs instead of a patch.',
     type: 'boolean',
   },
-  failWithNoTests: {
-    default: false,
-    description: 'Will fail if no tests are found (for example while using `--testPathPattern`.)',
-    type: 'boolean',
-  },
   findRelatedTests: {
     default: undefined,
     description: 'Find related tests for a list of source files that were ' +
@@ -290,6 +285,11 @@ const options = {
       'also specified.',
     type: 'string',
   },
+  passWithNoTests: {
+    default: false,
+    description: 'Will not fail if no tests are found (for example while using `--testPathPattern`.)',
+    type: 'boolean',
+  },
   preset: {
     description: "A preset that is used as a base for Jest's configuration.",
     type: 'string',

diff --git a/packages/jest-cli/src/runJest.js b/packages/jest-cli/src/runJest.js
@@ -182,12 +182,12 @@ const runJest = async (
   if (!allTests.length) {
     const noTestsFoundMessage = getNoTestsFoundMessage(testRunData, pattern);
 
-    if (argv.failWithNoTests) {
+    if (argv.passWithNoTests) {
+      new Console(pipe, pipe).log(noTestsFoundMessage);
+    } else {
       new Console(pipe, pipe).error(noTestsFoundMessage);
 
       process.exit(1);
-    } else {
-      new Console(pipe, pipe).log(noTestsFoundMessage);
     }
   } else if (
     allTests.length === 1 &&