validate testURL as CLI option

jestjs · Oct 6, 2020 · d5f5cb5 · d5f5cb5
1 parent 999ee46
commit d5f5cb5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,7 @@
 - `[jest-console]` Add `Console` constructor to `console` object ([#10502](https://github.com/facebook/jest/pull/10502))
 - `[jest-globals]` Fix lifecycle hook function types ([#10480](https://github.com/facebook/jest/pull/10480))
 - `[jest-runtime]` Remove usage of `vm.compileFunction` due to a performance issue ([#10586](https://github.com/facebook/jest/pull/10586))
+- `[jest-validate]` Validate `testURL` as CLI option ([#10595](https://github.com/facebook/jest/pull/10595))
 
 ### Chore & Maintenance
 

diff --git a/packages/jest-validate/src/__tests__/validateCLIOptions.test.js b/packages/jest-validate/src/__tests__/validateCLIOptions.test.js
@@ -19,6 +19,19 @@ test('validates yargs special options', () => {
   expect(validateCLIOptions(argv, options)).toBe(true);
 });
 
+test('validates testURL', () => {
+  const options = {
+    testURL: {
+    description: 'This option sets the URL for the jsdom environment.',
+    type: 'string'
+    },
+  };
+  const argv = {
+    testURL: 'http://localhost',
+  };
+  expect(validateCLIOptions(argv, options)).toBe(true);
+});
+
 test('fails for unknown option', () => {
   const options = ['$0', '_', 'help', 'h'];
   const argv = {

diff --git a/packages/jest-validate/src/validateCLIOptions.ts b/packages/jest-validate/src/validateCLIOptions.ts
@@ -79,6 +79,7 @@ export default function validateCLIOptions(
   const unrecognizedOptions = Object.keys(argv).filter(
     arg =>
       !allowedOptions.has(camelcase(arg)) &&
+      !allowedOptions.has(arg) &&
       (!rawArgv.length || rawArgv.includes(arg)),
     [],
   );