Fix bug with inline snapshots when snapshot is string not template li…

…teral
jestjs · Aug 31, 2023 · e0daf57 · e0daf57
1 parent f2c78d0
commit e0daf57
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Fixes
 
+- `[jest-snapshot]` Allow for strings as well as template literals in inline snapshots
+
 ### Performance
 
 - `[@jest/create-cache-key-function]` Cache access of `NODE_ENV` and `BABEL_ENV` ([#14455](https://github.com/jestjs/jest/pull/14455))

diff --git a/packages/jest-snapshot/src/InlineSnapshots.ts b/packages/jest-snapshot/src/InlineSnapshots.ts
@@ -274,7 +274,7 @@ const traverseAst = (
     snapshotMatcherNames.push(callee.property.name);
 
     const snapshotIndex = args.findIndex(
-      ({type}) => type === 'TemplateLiteral',
+      ({type}) => type === 'TemplateLiteral' || type === 'StringLiteral',
     );
 
     const {snapshot} = inlineSnapshot;

diff --git a/packages/jest-snapshot/src/__tests__/InlineSnapshots.test.ts b/packages/jest-snapshot/src/__tests__/InlineSnapshots.test.ts
@@ -738,3 +738,23 @@ test('saveInlineSnapshots() prioritize parser from project/editor configuration'
       '});\n',
   );
 });
+
+test('saveInlineSnapshots() replaces string literal, not just template literal', () => {
+  const filename = path.join(dir, 'my.test.js');
+  fs.writeFileSync(filename, 'expect("a").toMatchInlineSnapshot("b");\n');
+
+  saveInlineSnapshots(
+    [
+      {
+        frame: {column: 13, file: filename, line: 1} as Frame,
+        snapshot: 'a',
+      },
+    ],
+    dir,
+    'prettier',
+  );
+
+  expect(fs.readFileSync(filename, 'utf-8')).toBe(
+    'expect("a").toMatchInlineSnapshot(`a`);\n',
+  );
+});