jest-matchers fails on IE10

[skovhus]

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Running latests jest-matchers in a IE10 environment it fails with

19 07 2017 13:42:43.316:INFO [IE 10.0.0 (Windows 8 0.0.0)]: Connected on socket -C3IcIu9DHLMDYfIAAAE with id 90097551
IE 10.0.0 (Windows 8 0.0.0) ERROR
  Object expected
  at webpack:///~/jest-matchers/build-es5/index.js:4994:0 <- tests.webpack.js:5330
IE 10.0.0 (Windows 8 0.0.0): Executed 0 of 0 ERROR (0.417 secs / 0 secs)

If the current behavior is a bug, please provide the steps to reproduce and either a repl.it demo through https://repl.it/languages/jest or a minimal repository on GitHub that we can yarn install and yarn test.

See

• Use jest-matchers for assertions instead of expect remix-run/history#468
• https://travis-ci.org/ReactTraining/history/builds/255264385?utm_source=github_status&utm_medium=notification

What is the expected behavior?
It shouldn't crash and the history tests should succeed.

Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
jest-matchers@20.1.0-delta.2

This is related to the work done in:

• jest-matchers contains untranspiled code #3360
• Better browser support #3421
• Add babel-transform-runtime to browser builds #3476
• Use rollup for browser builds #3532

[skovhus]

FYI @SimenB

[SimenB]

These are always fun to debug...

@cpojer do we have a minimum supported browser target?

[skovhus]

@SimenB @cpojer I think we at least needs to support IE10, which should be do-able. : )

[SimenB]

Dug into this. Chalk uses Object.setPrototypeOf, which is transformed into some weird core-js thingy which fails. Not sure why it fails like it does? It's been over a year since I had to deal with this sort of error...

https://github.com/chalk/chalk/blob/23092eefd2401f1a41d9fb931ce9091ec2f624c5/index.js#L38-L39

The polyfill:

Is Rollup doing something weird?

[skovhus]

Nice, reached the same conclusion just 5 minutes ago. 👍 (But should have use the nice debugger in IE like you did instead of console logs) 😊

Maybe some babel core stuff is not included correctly. 🤔

[SimenB]

Maybe the polyfill doesn't work in IE10, seems like it relies on __proto__.

https://github.com/zloirock/core-js/blob/0bc7a9ea75fd1a604cc6c99eb755c32a08afda9a/library/modules/_set-proto.js

[skovhus]

I'm using Babel with polyfills for a fairly big IE9 project (don't get me started on that), and everything just works there. So I think we can get it to work. : )

[SimenB]

Yeah, we're hitting the undefined case there.

So we need to polyfill it for IE10.

[skovhus]

I think babel-polyfill should do this.

[SimenB]

babel-polyfill is just core-js. And core-js is unable to polyfill it

[SimenB]

https://github.com/chalk/chalk/pull/163/files#r128383883

[skovhus]

core-js is unable to polyfill it

I think you are right. : )

[SimenB]

Special case to some stubbed-out implementation of Chalk when building for the browser? We don't care about the colors

[skovhus]

Stubbed out version might be the best option right now. 👍🏻

As we are retrofitting browser support on a lot of dependencies, stubbing out dependencies might be also be useful in the future.

Running the Karma integration tests in IE10 would also be good to avoid regressions.

I'll it be able to look into this the next week. 😎🏝

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.