Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Enter" doesn't interrupt tests anymore #6598

Closed
gaearon opened this issue Jul 2, 2018 · 3 comments · Fixed by #6601
Closed

"Enter" doesn't interrupt tests anymore #6598

gaearon opened this issue Jul 2, 2018 · 3 comments · Fixed by #6601

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 2, 2018

🐛 Bug Report

Enter doesn't interrupt tests.

To Reproduce

Run the test watcher. Press Enter while tests are running.

Expected behavior

Tests should get interrupted, like on p. I think that used to work but got broken (?)
@gaearon
Copy link
Contributor Author

gaearon commented Jul 2, 2018

cc @cpojer

@gaearon gaearon mentioned this issue Jul 2, 2018
Closed
11 tasks
@rickhanlonii
Copy link
Member

Looks like this was broken here: 7c78f3d#diff-d8a3d0a3a8b42ab87b18835ad8f7cb46R266

@rickhanlonii rickhanlonii mentioned this issue Jul 2, 2018
Merged
facebook-github-bot pushed a commit to facebookarchive/prepack that referenced this issue Jul 2, 2018
@gaearon @facebook-github-bot
Make React tests fast (#2187)
5159b0d 
Summary:
Currently we have a single giant file with all tests, and a giant snapshot. This is both slow, and hard to work with and iterate on.

In this PR I will refactor our test setup.

- [x] Split it up into multiple files (gets the test running from 45s to 27s)
- [x] Run Prettier on test files
- [x] Split tests further for better performance
- [x] Make it possible to run one test file
- [x] Fix the issue with double test re-runs in watch mode on changes in the test file
- [x] Refactor error handling
- [x] Run Prettier on fixtures
- [x] Add a fast mode with `yarn test-react-fast <Filename>`
- [x] Fix double reruns on failure

Potential followups:
- [x] Figure out why test interruption broke (need jestjs/jest#6599 and jestjs/jest#6598 fixed)
- [x] Revisit weird things like `this['React']` assignment with a funny comment in every test
Closes #2187

Differential Revision: D8713639

Pulled By: gaearon

fbshipit-source-id: 5edbfa4e61610ecafff17c0e5e7f84d44cd51168
@gaearon gaearon mentioned this issue Jul 4, 2018
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix enter to interrupt rickhanlonii/jest
2 participants
@gaearon @rickhanlonii