-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With Retries enabled, a failure in beforeAll is not thrown. #8221
Comments
/cc @palmerj3 |
Thanks for the steps to reproduce! I'll have a look. |
I have a fix in the works. Thanks for reporting! |
Awesome! Thanks for being ontop of it! |
## Summary Fixes #8221 If test retries are enabled - do not retry tests when beforeAll/beforeEach fails. ## Test plan Added additional e2e test to test for this regression
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
🐛 Bug Report
We are using jest.retryTimes(3) with the following versions:
"jest": "^24.5.0",
"jest-circus": "^24.5.0",
"jest-junit": "^6.3.0",
It seems when a failure in beforeAll happens, it just continues to the
it
part of the test.if the
it
depends on anything in thebeforeAll
to happen, we see a stack trace which is unrelated to what actually failed.. undefined errors, etc.If a failure occurs in beforeAll it should be thrown and the tests should fail at that point.
To Reproduce
Steps to reproduce the behavior:
jest.retries(3)
Also created a test repo. You can use the link below and run test in
some-test.requests.spec.js
Expected behavior
Actual behavior
it
part of the test. Exception does not reference the original exception that happened in the beforeAll.Link to repl or repo (highly encouraged)
https://github.com/TonyG623/jest-retry-before-all-failure
Run
npx envinfo --preset jest
Paste the results here:
The text was updated successfully, but these errors were encountered: