-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing for mercurial changed files #8653
Comments
I have same problem.
|
Yeah, they fail for me as well. I've never used mercurial, so I have no real point of reference here. Maybe @scotthovestadt can help? |
@SimenB I'd be happy to open a PR if the solution I've described when I opened the issue is valid, but given that I'm not an SVN expert, I'd like to confirm before doing it:
|
I have absolutely no clue, unfortunately... Maybe @quark-zju knows? |
This is mostly likely related to phase configuration. In Mercurial, the common workflow is that the "master" branch has public commits, and feature branches have "draft" commits. I suspect all commits are "drafts" and there are commits that should be public but are not public in these cases. In that case, I think the revset can be changed to:
to work with incorrect phase setup (all commits are draft) while still being able to take advantage of phases to detect draft feature branch. Explanation:
|
This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
🐛 Bug Report
Currently, when cloning straight from the current version
master
the test for getting changed files inhg
is failing.I'm running the latest version of
hg
(5.0.1) in an old Mac I have but the same happens in any of the other machines I've cloned jest into.The error I get is due to the pattern we use to specify a
revset
returning an empty revision range.Command failed: hg status -amnu --rev min((!public() & ::.)+.)^ /var/folders/p0/0npmk50s57v5sgzb_s9z2xmc0000gn/T/jest-changed-files-test-dir /var/folders/p0/0npmk50s57v5sgzb_s9z2xmc0000gn/T/jest-changed-files-test-dir/nested-dir /var/folders/p0/0npmk50s57v5sgzb_s9z2xmc0000gn/T/jest-changed-files-test-dir/nested-dir/second-nested-dir abort: empty revision range at makeError (node_modules/execa/index.js:181:11)
Related PRs:
To Reproduce
Steps to reproduce the behavior:
jest
hg
yarn test
)Expected behavior
The test linked above should pass since the
withAncestor
option should return both the current changes and the changes in the last commit. Currently, the pattern we use to specify arevset
errors because the pattern specifies an empty range.I managed to solve this locally myself, by using
ancestors(.)::0
as the argument for--revset
, but I'm not sure whether this solution covers all necessary edge-cases. Since I don't usemercurial
myself I thought it was better to open an issue and see what other mercurial users think of this solution. If this is a satisfactory solution I can open a PR as I already have these changes commited to this branch.Link to repl or repo (highly encouraged)
As per the
steps to reproduce
section, this repo is its own reproducible repo.Run
npx envinfo --preset jest
Paste the results here:
The text was updated successfully, but these errors were encountered: