-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: upgrade source-map to @cspotcode/source-map #12485
Comments
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Happy to test this out after cspotcode/node-source-map-support#37 lands 👍 |
Or rather, migrate to using |
Oh I thought this was superceded by the switch to trace-mapping.
Does jest use source-map-support, which hooks the node runtime to rewrite
stack traces? I thought it only used source-map -- now trace-mapping --
the underlying sourcemap library. Boy these names can get confusing.
EDIT: Nevermind, now I remember we've talked about this and it *is* used. I guess I'm becoming forgetful.
I hopefully have time for this over the weekend.
…On Thu, Apr 21, 2022, 6:55 AM Simen Bekkhus ***@***.***> wrote:
Or rather, migrate to using @cspotcode/source-map-support
—
Reply to this email directly, view it on GitHub
<#12485 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC35OATGQEANCK54AKG7W3VGEX3PANCNFSM5PGGJEPA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yep, that sounds right 😀 |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
I have been experiencing this issue on larger code bases. |
🚀 Feature Proposal
Is there any interest in upgrading from
source-map
to@cspotcode/source-map
? If so, I can attempt a pull request to see if all the tests pass.Motivation
I see it mentioned in a few places that jest is blocked from upgrading past source-map 0.6.1.
mozilla/source-map#331 (comment)
https://github.com/facebook/jest/blob/199f9811ae68b15879cbe18b7ef7ebd61eefcf23/packages/jest-transform/src/types.ts#L29
@cspotcode/source-map
has a sync API but the improved WASM-enabled performance of newersource-map
.Example
No response
Pitch
It would improve performance. By how much, I'm not sure.
The text was updated successfully, but these errors were encountered: