Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: upgrade source-map to @cspotcode/source-map #12485

Open
cspotcode opened this issue Feb 24, 2022 · 8 comments
Open

[Feature]: upgrade source-map to @cspotcode/source-map #12485

cspotcode opened this issue Feb 24, 2022 · 8 comments

Comments

@cspotcode
Copy link
Contributor

🚀 Feature Proposal

Is there any interest in upgrading from source-map to @cspotcode/source-map? If so, I can attempt a pull request to see if all the tests pass.

Motivation

I see it mentioned in a few places that jest is blocked from upgrading past source-map 0.6.1.

mozilla/source-map#331 (comment)
https://github.com/facebook/jest/blob/199f9811ae68b15879cbe18b7ef7ebd61eefcf23/packages/jest-transform/src/types.ts#L29

@cspotcode/source-map has a sync API but the improved WASM-enabled performance of newer source-map.

Example

No response

Pitch

It would improve performance. By how much, I'm not sure.

@cspotcode
Copy link
Contributor Author

I ran the tests locally, but not the mercurial tests, since it seems like they are always failing: #8653

They are passing, so I submitted #12486 to allow you to run the full test suite if you want.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 26, 2022
@SimenB
Copy link
Member

SimenB commented Apr 21, 2022

Happy to test this out after cspotcode/node-source-map-support#37 lands 👍

@github-actions github-actions bot removed the Stale label Apr 21, 2022
@SimenB
Copy link
Member

SimenB commented Apr 21, 2022

Or rather, migrate to using @cspotcode/source-map-support

@cspotcode
Copy link
Contributor Author

cspotcode commented Apr 21, 2022 via email

@SimenB
Copy link
Member

SimenB commented Apr 21, 2022

Yep, that sounds right 😀

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 21, 2022
@SimenB SimenB added Pinned and removed Stale labels May 23, 2022
@chrisryanouellette
Copy link

I have been experiencing this issue on larger code bases.
It is not consistent but when it does come up most PR are blocked until some other changes allows it to succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants