Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toMatchObject() fails on circular objects (RangeError) #8663

Closed
leoselig opened this issue Jul 9, 2019 · 1 comment
Closed

toMatchObject() fails on circular objects (RangeError) #8663

leoselig opened this issue Jul 9, 2019 · 1 comment

Comments

@leoselig
Copy link

leoselig commented Jul 9, 2019

🐛 Bug Report

Calling expect().toMatchObject() throws with a Range Error (Maximum call stack size exceeded) when the expected and actual objects both contain circular references.

To Reproduce

import { expect } from "expect";

const obj = {};
obj.self = obj;

expect(obj).toMatchObject(obj); // works
expect(obj).toMatchObject(obj); // throws RangeError (Maximum call stack size exceeded)

The commit 0974497 in my fork adds a test case for the broken behavior.

Expected behavior

In the above example, I'd expect both expect()-chains to return undefined and not throw anything (since obj is a valid subset of itself).

Link to repl or repo

https://repl.it/repls/RosyRipeKey

Run npx envinfo --preset jest

  System:
    OS: macOS 10.14.5
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
  Binaries:
    Node: 8.11.1 - ~/.nvm/versions/node/v8.11.1/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v8.11.1/bin/npm
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 13, 2019
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 13, 2019
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 13, 2019
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 13, 2019
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 13, 2019
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 14, 2019
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 15, 2019
lucasfcosta added a commit to lucasfcosta/jest that referenced this issue Jul 15, 2019
@jeysal jeysal closed this as completed in 1b38e11 Jul 28, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant