Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ts-jest mock util functions in jest core #9534

Closed
ahnpnl opened this issue Feb 7, 2020 · 8 comments · Fixed by #12089
Closed

Include ts-jest mock util functions in jest core #9534

ahnpnl opened this issue Feb 7, 2020 · 8 comments · Fixed by #12089

Comments

@ahnpnl
Copy link
Contributor

ahnpnl commented Feb 7, 2020

🚀 Feature Proposal

This proposal is for the outcome of the discussion in ts-jest that includests-jest mock util functions in jest core.

Motivation

Users don't have to install ts-jest anymore to access these util mocks, just need to install jest.

Pitch

Suggestion from @thymikee that it should belong to jest core

@SimenB
Copy link
Member

SimenB commented Feb 9, 2020

Yeah, I think this is a good idea. There's been some changes to mocks in @types/jest as well, would be nice to bring the best features of both into Jest itself (at which point DT could pull the features from us instead).

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/a68259ee8883cc9899463fe79a78bb49a9d2f6de/types/jest/index.d.ts#L1042-L1298

@leonardovillela
Copy link
Contributor

Hi, can I take this issue?

@SimenB
Copy link
Member

SimenB commented Feb 29, 2020

Yes please! 🙂

@leonardovillela
Copy link
Contributor

Hi @SimenB, I'm working on this issue and don't have much progress. I have some doubts about the approach that I should follow. Actually I didn't understand your first comment really well. Should I try to "use" definition on @types/jest on jest-mock package and work on top of it to add mocked fn from ts-jest?

@lee-leonardo
Copy link

Has this been abandoned? I can take a look

@ahnpnl
Copy link
Contributor Author

ahnpnl commented Mar 18, 2020

Include as well another proposal in this area from kulshekhar/ts-jest#1065

@lee-leonardo
Copy link

got it, will do

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants