Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding types to the mock utils in jest #9682

Closed

Conversation

lee-leonardo
Copy link

adding the types file here, pretty sure this is the correct spot, not in actual core repo.

Summary

In response to #9534 the instructions were to add to ts definitions to jest-core.
I am pretty certain this is not actually in the jest-core file as a file already exists but rather in the mock

Test plan

Ran yarn jest to verify my changes were non-breaking.
As this is a types file, not 100% sure what tests to write, maybe output? Example would help.

@SimenB
Copy link
Member

SimenB commented Feb 23, 2022

@lee-leonardo sorry I missed this! Is this still needed?

/cc @mrazauskas or is it covered by your recent changes?

@mrazauskas
Copy link
Contributor

At first glanced, the types here look like a copy from @types/jest. These there already included and recently I reworked / improved some parts. This only means that quit some rebasing would be needed.

Seems like only to details are missing in current types from this PR: TSDoc comments in MockInstance and moving types to separate file (I was about to do this soon). Perhaps new PR would be better idea (and more easy to do) than rebasing this one?

@SimenB
Copy link
Member

SimenB commented Feb 23, 2022

Perhaps new PR would be better idea (and more easy to do) than rebasing this one?

Yeah, I think so 👍

@SimenB SimenB closed this Feb 23, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants