fix(worker): downgrade minimum required node version to 10.13 #10352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Kelly <josh@codecog.dev>
SimenB
requested changes
Aug 1, 2020
An exception needs to be added against the assertion of the node engine version for sub packages. jest-worker requires a lower version than root and the current assertion fails the build. Signed-off-by: Josh Kelly <josh@codecog.dev>
SimenB
approved these changes
Aug 2, 2020
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10142
Closes #10145
Change requested to downgrade the minimum required version of node to 10.13 to solve an issue people were experiencing when using the jest-worker as a dependency